ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic
https://ghiscoding.github.io/slickgrid-universal/
Other
89 stars 29 forks source link

feat(OData): add `filterQueryOverride` to OData Service #1536

Closed zewa666 closed 5 months ago

zewa666 commented 5 months ago

Hey @jr01 and @ghiscoding,

In order to continue the discussion from https://github.com/ghiscoding/slickgrid-universal/pull/1532 I'd like to start with this PR as a discussion basis.

I'm not sure I fully understood the original requirements but here's what I came up with so far:

So my goal was to stay as generic as possible in order to support as much use cases as there might be.

Let me know what you guys think of this. Happy change according to our discussions outcome

stackblitz[bot] commented 5 months ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (884b6e0) to head (f441a72). Report is 6 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1536 +/- ## ======================================== + Coverage 99.8% 99.8% +0.1% ======================================== Files 198 198 Lines 21680 21685 +5 Branches 7248 7112 -136 ======================================== + Hits 21619 21624 +5 Misses 55 55 Partials 6 6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ghiscoding commented 5 months ago

hey guys, so Angular 18 just came out (an hour ago), so I might release Angular-Slickgrid 8.0 tonight (done) and release a minor in the next few days (or weeks) when we're satisfied with this PR (I'll also have to see if we can duplicate this to GraphQL Service as well).

For the PR itself, I think all questions were resolved, I'm ok with the changes and discussion we had. Cheers

zewa666 commented 5 months ago

sounds great, I'll try to get the tests and docs in place.

zewa666 commented 5 months ago

I got the example properly updated, docs and tests added.

I'm not really sure what to do on the GraphQL side of things so I'd leave that up to you.

ghiscoding commented 5 months ago

Yeah no worries, I'll take a look later to see if it's doable or not to update GraphQL as well. I spotted a couple of typos in your docs when I read it quickly last, I'll take another look at it and add comments. Thanks a lot for all of that, always nice to get very detailed contributions from your side :)

ghiscoding commented 5 months ago

@jr01 would you mind doing a quick review as well if you have time to spare? Thanks :)

zewa666 commented 5 months ago

I'll address the review feedback. thx

jr01 commented 5 months ago

LGTM