Closed zewa666 closed 5 months ago
Run & review this pull request in StackBlitz Codeflow.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.8%. Comparing base (
884b6e0
) to head (f441a72
). Report is 6 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
hey guys, so Angular 18 just came out (an hour ago), so I might release Angular-Slickgrid 8.0 tonight (done) and release a minor
in the next few days (or weeks) when we're satisfied with this PR (I'll also have to see if we can duplicate this to GraphQL Service as well).
For the PR itself, I think all questions were resolved, I'm ok with the changes and discussion we had. Cheers
sounds great, I'll try to get the tests and docs in place.
I got the example properly updated, docs and tests added.
I'm not really sure what to do on the GraphQL side of things so I'd leave that up to you.
Yeah no worries, I'll take a look later to see if it's doable or not to update GraphQL as well. I spotted a couple of typos in your docs when I read it quickly last, I'll take another look at it and add comments. Thanks a lot for all of that, always nice to get very detailed contributions from your side :)
@jr01 would you mind doing a quick review as well if you have time to spare? Thanks :)
I'll address the review feedback. thx
LGTM
Hey @jr01 and @ghiscoding,
In order to continue the discussion from https://github.com/ghiscoding/slickgrid-universal/pull/1532 I'd like to start with this PR as a discussion basis.
I'm not sure I fully understood the original requirements but here's what I came up with so far:
filterPredicate
as ODataOptionSo my goal was to stay as generic as possible in order to support as much use cases as there might be.
Let me know what you guys think of this. Happy change according to our discussions outcome