ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic
https://ghiscoding.github.io/slickgrid-universal/
MIT License
83 stars 26 forks source link

Quotes newlines/tabs excelcopybuffer #1559

Closed zewa666 closed 3 months ago

zewa666 commented 3 months ago

Describe the bug

With the ExcelCopyBuffer I'd expect if a paste text is quoted with doublequotes, newlines within that text shouldn't break to new cells. Also when tabs are contained, the text after them is cut off.

I just wanted to check back with you whether you @ghiscoding too think this is a wrong behavior. If so, I'll create a PR to fix that.

Reproduction

Which Framework are you using?

Angular

Environment Info

| Executable          | Version |
| ------------------- | ------- |
| (framework used)    | Angular |
| Slickgrid-Universal | latest |
| TypeScript          | VERSION |
| Browser(s)          | VERSION |
| System OS           | VERSION |

Validations

ghiscoding commented 3 months ago

@zewa666 that seems valid indeed, I'm not sure when you were going to push a fix but I was expecting to start releasing tonight after work. I guess that fix will coming in next patch with the other PRs you had in mind in that case

zewa666 commented 3 months ago

exactly. I'll finish the other together with this one and let you know afterwards. most things are monkey-patchable so I currently often add my workaround and whenever the new version is out I simply drop my mods, so no pressure from my side