Closed ghiscoding closed 5 months ago
Run & review this pull request in StackBlitz Codeflow.
Attention: Patch coverage is 99.92587%
with 1 line
in your changes missing coverage. Please review.
Project coverage is 99.8%. Comparing base (
4d69bc0
) to head (066124c
).
Files | Patch % | Lines |
---|---|---|
packages/common/src/core/slickGrid.ts | 99.6% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
--isolatedDeclarations
flag, which requires explicit return type, to speed up monorepo builds, see TypeScript 5.5 RC release blog post for more infoisolatedDeclarations
flag can be added intotsconfig.base.json
but I have disabled it for now because it throws a thousand of errors, I've only slowly started to fix some of these errorshasData()
util to be a duplicate ofisDefined()
declared in the same util file, so let's removehasData()
and keep the other methodNOTE: this PR is speed up builds but as mentioned by the TypeScript team, this will only start to happen in future iteration of TypeScript when more tools start to integrate it. However it is still good to start enabling the flag early and do the changes now.