fix(GraphQL): filter `<>` is `Not_Contains` instead of `Not_Equal`

ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic

https://ghiscoding.github.io/slickgrid-universal/

Other

89 stars 29 forks source link

fix(GraphQL): filter `<>` is `Not_Contains` instead of `Not_Equal` #1571

Closed ghiscoding closed 4 months ago

ghiscoding commented 4 months ago

while investigating for issue #1569, I found out that the GraphQL <> was set to be the equivalent of != but this is in fact false, since the <> is meant to represent Not_Contains while != is meant to represent Not_Equals and they both work differently since <> is for a substring but the != is for the entire string
it is also related to the PR #1570
Note that OData doesn't have a "Not Contains" query filter and so I only made the modification for GraphQL (OData has its own switch case for each operator)

stackblitz[bot] commented 4 months ago

Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (9837ef1) to head (3be073c).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1571 +/- ## ======================================= Coverage 99.8% 99.8% ======================================= Files 198 198 Lines 21731 21731 Branches 7278 7005 -273 ======================================= Hits 21670 21670 Misses 61 61 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.