Closed zewa666 closed 1 month ago
Run & review this pull request in StackBlitz Codeflow.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.8%. Comparing base (
f03cc6c
) to head (e68bc6b
). Report is 1 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@zewa666 oh I'm not sure why you closed your PR?
I had another possible problem with the .textContent
, this will read all element texts but is that really ideal though? I mean I just tested this with an HTML element that has some text and a button with text and it gives me what is shown below (the button text is also pulled). However, I'm not sure that we can do much about it?!?
that is using the following code
const div = document.createElement('div');
const button = document.createElement('button');
button.className = 'button button-small';
button.textContent = 'click';
button.addEventListener('click', () => alert('hi'));
div.appendChild(document.createTextNode('Column 1 '));
div.appendChild(button);
this.columnDefinitions = [
{
id: 'sel', name: div, field: 'num', width: 80, type: FieldType.number,
excludeFromExport: true,
resizable: true,
filterable: true,
selectable: false,
focusable: false
},
fixes #1605