search

ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic
https://ghiscoding.github.io/slickgrid-universal/
MIT License
82 stars 26 forks source link

fix: queryselector should support numeric ids #1612

Closed zewa666 closed 1 month ago

zewa666 commented 1 month ago

I just tried to integrate the composite editor and it failed with the error that [data-editor=1234] is an invalid selector. Guess what, my column ids are numeric strings :)

stackblitz[bot] commented 1 month ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (e34971d) to head (8951984). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1612 +/- ## ======================================== + Coverage 99.8% 99.8% +0.1% ======================================== Files 198 198 Lines 21795 21796 +1 Branches 7302 7303 +1 ======================================== + Hits 21734 21735 +1 + Misses 61 55 -6 - Partials 0 6 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ghiscoding commented 1 month ago

haha I didn't think about that special case, thanks again :)