Closed good-ghost closed 4 months ago
Run & review this pull request in StackBlitz Codeflow.
I missed some part of code editing.. Sorry make inconvenience.
@good-ghost
your PR seems ok (without testing it), you were just missing HTMLSpanElement
on the checkboxSelectionFormatter
function on line 351 (or around there)
- protected checkboxSelectionFormatter(row: number, _cell: number, _val: any, _columnDef: Column, dataContext: any, grid: SlickGrid): DocumentFragment | null {
+ protected checkboxSelectionFormatter(row: number, _cell: number, _val: any, _columnDef: Column, dataContext: any, grid: SlickGrid): DocumentFragment | HTMLSpanElement | null {
if (dataContext && this.checkSelectableOverride(row, dataContext, grid)) {
const UID = this.createUID() + row;
return this.createCheckboxElement(`selector${UID}`, !!this._selectedRowsLookup[row]);
}
return null;
}
you were right, it looks like I missed that Document Fragment, so making this change makes sense
In the Salesforce environment, DocumentFragment is not supported. So add condition to createElement for checkboxSelectorColumn.