Closed good-ghost closed 3 months ago
Run & review this pull request in StackBlitz Codeflow.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.8%. Comparing base (
c03b863
) to head (ab6aaff
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@good-ghost are you having some problems with the creation of a Pull Request? Let me know if you need help, your PR seems correct this time
@good-ghost reopening since your Pull Request seems valid to me. Have you tested it in Salesforce? if you want to bundle it and update the zip file for testing, you can run this pnpm command from the root of the project (the zip is located in packages/vanilla-force-bundle/dist-grid-bundle-zip
)
pnpm run bundle:zip
EDIT
ahh now I see why you had problem with the PR, I have Husky in place to make sure the PR title follows the Conventional Commit guideline and you were simply missing fix: ...
as prefix to the PR title (see Conventional Commit guideline for more info)
@good-ghost I'll go ahead and merge this since I think this is correct now. I'll push a new release today and will update the zip file as well by the end of the day. Thanks for your contribution
EDIT
Released in v5.4.0 and zip file updated. Thanks again for the contribution ⭐
Salesforce does not supoort DocumentDefragment, so add condition preventDocumentFragmentUsage for checkboxSelectorColumn.