ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic
https://ghiscoding.github.io/slickgrid-universal/
MIT License
82 stars 26 forks source link

chore: reproduce bug #1619

Open zewa666 opened 1 month ago

zewa666 commented 1 month ago

!!!DO NOT MERGE, JUST FOR ERROR REPRODUCTION AND SEEING IT IN STACKBLITZ!!!

Here's the repro of https://github.com/ghiscoding/slickgrid-universal/issues/1618. if you take a look at the example12 you'll notice that the duration column now has a custom editor in use. If you change the value of a duration cell, you'll notice that the cost column should be updated to 1234657 as well after cell leave.

If you do the same via the composite editor however, that's not happening.

stackblitz[bot] commented 1 month ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (0c2aca8) to head (c7c508c). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1619 +/- ## ======================================= Coverage 99.8% 99.8% ======================================= Files 198 198 Lines 21796 21796 Branches 7304 7023 -281 ======================================= Hits 21735 21735 - Misses 55 61 +6 + Partials 6 0 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ghiscoding commented 2 days ago

I was trying to update and rebase the PR, I've never done that, but I guess it's only doable by the author of the PR? I'd really like to know if there's a 1-click way of doing a rebase/force push to the PR to make in sync with latest code in master.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/keeping-your-pull-request-in-sync-with-the-base-branch

Similar to what Renovate does anytime its open PR needs to be rebase, I'm just curious to know how this is done

image