fix: use setTimeout/setInterval from window object with correct TS type

ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic

https://ghiscoding.github.io/slickgrid-universal/

MIT License

82 stars 26 forks source link

fix: use setTimeout/setInterval from window object with correct TS type #1643

Closed ghiscoding closed 3 weeks ago

ghiscoding commented 3 weeks ago

newest version of @types/node and TypeScript is sometime throwing some errors, especially in Angular "TS2503: Cannot find namespace 'NodeJS [plugin angular-compiler]'"
I thought that we should always use setTimeout directly but its type is NodeJS.timeout type, however we should be using window.setTimeout with a return type of number instead since our project is always a Browser App hence the use of the window object

stackblitz[bot] commented 3 weeks ago

Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (a1977a8) to head (7fc57ce). Report is 14 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1643 +/- ## ======================================== - Coverage 99.8% 99.8% -0.0% ======================================== Files 198 198 Lines 21859 21849 -10 Branches 7310 7162 -148 ======================================== - Hits 21796 21786 -10 + Misses 63 57 -6 - Partials 0 6 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.