Closed ghiscoding closed 1 month ago
Run & review this pull request in StackBlitz Codeflow.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 99.8%. Comparing base (
5ee077d
) to head (ce02f0f
). Report is 2 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
grid.onRendered
is already being called in many use cases, so there's no need to subscribe to so many events when we know that theonRendered
will be called anyway, so we can get rid of many of these events that was duplicating the work (and slightly bad for perf)onColumnsResized
,onColumnsReordered
,onColumnPickerColumnsChanged
, .... will all trigger theonRendered
, so there's really no need to duplicate the work when we can subscribe to a lot less events to do the same work