search

ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic
https://ghiscoding.github.io/slickgrid-universal/
Other
90 stars 29 forks source link

fix: hiding column(s) returned incorrect Grid State changes data #1737

Closed ghiscoding closed 2 weeks ago

ghiscoding commented 2 weeks ago

hiding columns is triggering an event which was maybe an array of columns in the past but it probably changed to an object of shape { columns, hiddenColumn } later on, however the Grid State subscribing to this event was never updated causing the Grid State to return incorrect data in its metadata

stackblitz[bot] commented 2 weeks ago

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (0ba1a93) to head (e570641). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1737 +/- ## ====================================== Coverage 99.8% 99.8% ====================================== Files 187 187 Lines 30752 30752 Branches 9777 9777 ====================================== Hits 30663 30663 Misses 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.