fix: hideColumnByIds wasn't hiding columns properly

ghiscoding / slickgrid-universal

Slickgrid-Universal is a monorepo which includes all Editors, Filters, Extensions, Services related to SlickGrid usage and is also Framework Agnostic

https://ghiscoding.github.io/slickgrid-universal/

Other

90 stars 29 forks source link

fix: hideColumnByIds wasn't hiding columns properly #1738

Closed ghiscoding closed 2 weeks ago

ghiscoding commented 2 weeks ago

tested a bit more after previous PR #1736 and found couple of small issues

calling hideColumnByIds() for multiple columns wasn't working correctly
also the options hideFromColumnPicker and hideFromGridMenu were incorrectly tied together meaning that when hideFromColumnPicker was enabled, it was also hiding them in the GridMenu as well which is wrong
lastly I've done a refactor to remove duplicate code of calling some grid commands when options autoResizeColumns and triggerEvent are enabled.

stackblitz[bot] commented 2 weeks ago

Run & review this pull request in StackBlitz Codeflow.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.8%. Comparing base (59a47b8) to head (e32d9f0). Report is 1 commits behind head on master.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1738 +/- ## ======================================== - Coverage 99.8% 99.8% -0.0% ======================================== Files 187 187 Lines 30752 30747 -5 Branches 9777 9778 +1 ======================================== - Hits 30663 30658 -5 Misses 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.