search

ghitchens / nerves_firmware_http

HTTP/REST micro service providing over-the-network firmware management
Other
26 stars 11 forks source link

Can't specify port for mix firmware.push #18

Open rabarar opened 7 years ago

rabarar commented 7 years ago

If you configure your firmware port to be anything other than the default port, mix firmware.push won't work - not sure how to specify a url or a port with the desired port number matching the one specified in the config.

fhunleth commented 7 years ago

I think this is the line that you're looking for: https://github.com/nerves-project/nerves_firmware_http/blob/master/lib/mix/firmware.push.ex#L54

I agree that it should be configurable. Would you want to try to add it as an option?

rabarar commented 7 years ago

I’ll take a look - also wanted to add ssl so you can configure where the upgrade is coming from and limit it to only authorized pushers.

On Jun 9, 2017, at 9:51 PM, Frank Hunleth notifications@github.com wrote:

I think this is the line that you're looking for: https://github.com/nerves-project/nerves_firmware_http/blob/master/lib/mix/firmware.push.ex#L54 https://github.com/nerves-project/nerves_firmware_http/blob/master/lib/mix/firmware.push.ex#L54 I agree that it should be configurable. Would you want to try to add it as an option?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/nerves-project/nerves_firmware_http/issues/18#issuecomment-307534549, or mute the thread https://github.com/notifications/unsubscribe-auth/AEOk-OE97QHj-i8_m1WN-wioAYoNuKcdks5sCfa3gaJpZM4N146i.

fhunleth commented 7 years ago

See #17 regarding authorization. I don't think that any work has happened on that issue. @ghitchens?

rabarar commented 7 years ago

I'll take a look

On Jun 10, 2017, at 8:02 PM, Frank Hunleth notifications@github.com wrote:

See #17 regarding authorization. I don't think that any work has happened on that issue. @ghitchens?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.