search

ghivert / sketch

A CSS-in-Gleam package, made to work with frontend, backend, with your favorite framework!
https://hexdocs.pm/sketch/
MIT License
48 stars 6 forks source link

Bugfix - Fixes in CSS generation - "sketch_css" #29

Closed josevictorferreira closed 1 week ago

josevictorferreira commented 2 weeks ago

This PR fixes 3 issues with CSS generation using "sketch_css":

  1. Property names are being generated with "_" instead of "-" as separator. Ex: z_index(100) was generated with the property name z_index instead of z-index.
  2. Properties with Int or Float values are being generated with empty values. Ex: opacity(1.0) generated as opacity: ;.
  3. Percent size values being generated with the wrong symbol. Ex: width(percent(100)) being generated as width: 100percent instead of width: 100%.
ghivert commented 2 weeks ago

Thanks for your PR! I see you're still pushing some fixes, do you think you have additional fixes to do, or is it OK as is?

josevictorferreira commented 2 weeks ago

I think it's OK, those are the only issues I've stumbled upon. The rest of the library is working great!

ghivert commented 1 week ago

Thank you!