ghliu / pytorch-ddpg

Implementation of the Deep Deterministic Policy Gradient (DDPG) using PyTorch
Apache License 2.0
569 stars 157 forks source link

Index error in ddpg.py? #1

Closed KuribohG closed 7 years ago

KuribohG commented 7 years ago

At line 127 in file ddpg.py, I think we should squeeze index 0 instead of index 1. However, because the two example game action space is only 1 dim, so this bug didn't show out.

I tried it on a high-dimensional action space, it only works when I change it to 0.

ghliu commented 7 years ago

Oops I guess you are right :sweat_smile: Thanks for the correction:)