ghmo / google-refine

Automatically exported from code.google.com/p/google-refine
0 stars 0 forks source link

Build script doesn't run under Ubuntu's /bin/sh (dash) #129

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I'm not actually 100% sure whether this is a problem with the build script or 
with the sh compatibility of Ubuntu's implementation, dash.

The command 

  ./gridworks windows_dist 1.4.9.0

gives the following warnings

./gridworks: 930: [[: not found
./gridworks: 930: [[: not found
./gridworks: 930: [[: not found

and then dies with 

  net.sf.launch4j.BuilderException: Invalid data: File version, should be 'x.x.x.x;

Using 

  bash gridworks windows_dist 1.4.9.0

instead completes the build successfully.

If nothing else, this problem should be documented for Linux users, but a 
solution would be preferable.

Original issue reported on code.google.com by tfmorris on 16 Sep 2010 at 6:18

GoogleCodeExporter commented 8 years ago
How about kist changing #!/bin/sh at the top to #!/bin/bash? I've tried pretty 
hard to avoid using any bash-isms in those shell scripts, but it's hard to know 
on mac since /bin/sh symlinks to /bin/bash.

thought?

Original comment by stefa...@google.com on 16 Sep 2010 at 4:35

GoogleCodeExporter commented 8 years ago
Ah, found this https://wiki.ubuntu.com/DashAsBinSh which helps a lot. I'll fix 
all the bashisms

Original comment by stefa...@google.com on 16 Sep 2010 at 9:52

GoogleCodeExporter commented 8 years ago
I think I fixed them all. Open this again if not the case.

Original comment by stefa...@google.com on 16 Sep 2010 at 10:18

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:58