Closed Fazilet1820 closed 5 months ago
All methods work. However it is confusing to use create and update. Create uses the DTO, but update doesn't. Also the DTO is near identical to the model, so currently there is no point to the DTO. The naming of fields in the DTO could be simpler example: adColor -> color.
I see string convert methods in the Enums but they are not used or don't work. There is no proper method for converting string input to Enum. An example of what I mean is if I write "red" for the color field it doesn't work. It need to be like the actual Enum "RED".
My suggestion is too remove DTO from create. If you do that I can approve of this pull request. DTO can be worked on in another branch.
I will write update method according to DTO and give the simpler names. But I think convert method which name is fromString works. Because when an user create an adevrtisement, he/she can not write red or dress etc. I mean that an user cannot type them, only select them from the enum class they are in. But now we can write them in big letters by hand to test. But when searching, even if it is written in small letters, it can see the result thanks to the fromstring method.
All of advertisement's filter uppdated and CRUD testad again Created filter by