search

ghoneycutt / puppet-module-facter

Puppet module to manage Facter
Other
2 stars 23 forks source link

Allow package_ensure to be any value #16

Closed treydock closed 10 years ago

treydock commented 10 years ago

The use case for this is ensuring a specific version of facter is installed across all systems.

Originally part of #15

ghoneycutt commented 10 years ago

@treydock Thanks for working with me here. I like this idea, and still need validation on the input. Could you use validate_string() and have a test where it is not a string and fails?

https://github.com/puppetlabs/puppetlabs-stdlib/tree/3.2.0#validate_string

treydock commented 10 years ago

@ghoneycutt Done. I replaced the test that I had changed to check an error was not raised to check an error is raised when package_ensure is not a string.

ghoneycutt commented 10 years ago

@treydock Thanks for the contribution! Added some spec testing to your commit in PR #17