search

ghoneycutt / puppet-module-facter

Puppet module to manage Facter
Other
2 stars 23 forks source link

add $purge_facts_d boolean to delete unmanaged txt files from facts.d… #32

Closed janvonde closed 9 years ago

janvonde commented 9 years ago

… directory

ghoneycutt commented 9 years ago

Suggest doing this separate and getting it merged then moving on to #33 so we can make incremental progress

janvonde commented 9 years ago

check, once this is done I will update my other pull request.

janvonde commented 9 years ago

I followed your instructions from #33 to install bundle and run the tests. This gives an error that I do not understand. The failure is:

Failures:

  1) facter should compile into a catalogue without dependency cycles
     Failure/Error: it { should compile.with_all_deps }
       error during compilation: Could not autoload puppet/type/package: Could not autoload puppet/provider/package/pkgdmg: cannot load such file -- plist on node 9000100750.fritz.box
     # ./spec/classes/init_spec.rb:4:in `block (2 levels) in <top (required)>'

Finished in 1.49 seconds (files took 0.51238 seconds to load)
69 examples, 1 failure

Failed examples:

rspec ./spec/classes/init_spec.rb:4 # facter should compile into a catalogue without dependency cycles

You can find the full output at http://0bin.net/paste/BSLAcQQtSOSfngpy#lg+WDCirPti0NLFRhyRtxOmPWjFTkOBCXearhrRNpSA

Can you give me a hint on how to understand and fix the error?

ghoneycutt commented 9 years ago

Not quite sure.

ghoneycutt commented 9 years ago

Hi @janvonde

I'm modifying your work in PR #37

Thanks a ton!