search

ghoneycutt / puppet-module-facter

Puppet module to manage Facter
Other
2 stars 23 forks source link

You are assuming that the user uses the same hiera 'key' that you do #48

Closed felipe1982 closed 7 years ago

felipe1982 commented 7 years ago

Hello.

Thank you for your module. I'd like to ask a question, as I am still learning a lot about puppet.

Here > https://github.com/ghoneycutt/puppet-module-facter/blob/master/manifests/init.pp#L127 it appears that we are assuming that the user will be using the hiera key facter::facts_hash but that might no always be the case. Is that a problem?

ghoneycutt commented 7 years ago

Thanks for reporting this issue. It will always be the case due to how puppet looks up parameters.