search

ghoneycutt / puppet-module-facter

Puppet module to manage Facter
Other
2 stars 23 forks source link

Update README facts_d_group #55

Closed NissesSenap closed 7 years ago

NissesSenap commented 7 years ago

Hi

Saw the following in the README, since i don't wan't to change anything else i didn't see any reason to create a commit but it would be nice to fix during the next commit:

facts_d_group Group of facst_file. Default: root

facts_d_mode Four digit mode of facts_file. Default: 0644

It should be facts_file_group and facts_file_mode

ghoneycutt commented 7 years ago

Thanks for creating this issue. I do not understand what you mean. Could you provide the expected behavior and then what you received or send a pull request.

NissesSenap commented 7 years ago

You have been to fast with the copy and paste, if you check in README.md

facts_file_owner

Owner of facts_file.

facts_d_group

Group of facst_file.

facts_d_mode

Four digit mode of facts_file.

It should say facts_file_mode and facts_file_group. If you search in the file you will see facts_d_mode and facts_d_group two times. But you have written a correct description.

ghoneycutt commented 7 years ago

I see now! Got it fixed. Thanks again!

ghoneycutt commented 7 years ago

https://github.com/ghoneycutt/puppet-module-facter/commit/e004051dcdf0df45ab6403a0fc8409ca204481bc