search

ghoneycutt / puppet-module-facter

Puppet module to manage Facter
Other
2 stars 23 forks source link

Update facter::fact to default 'facts_dir' to 'facter::facts_d_dir'. #61

Closed fatmcgav closed 6 years ago

fatmcgav commented 6 years ago

Add test case to exercise and fix failing test due to pre_condition.

ghoneycutt commented 6 years ago

Thanks for the contribution @fatmcgav

We're currently working on a new version of the module that drops support for Puppet 3 in the puppet5 branch. Perhaps you would like to target your change against that?

https://github.com/ghoneycutt/puppet-module-facter/tree/puppet5

https://github.com/ghoneycutt/puppet-module-facter/issues/57

fatmcgav commented 6 years ago

@ghoneycutt That's probably sensible... I'll update PR now :)

fatmcgav commented 6 years ago

Hmm, i'm not sure why Github has picked up 3 other commits on that forced update... :s

But same change applied to puppet5 branch :)

Edit: Ah, of course I do... the base on the PR is wrong... New one incoming :)

fatmcgav commented 6 years ago

Superseded by #62