Adding support for Windows

ghoneycutt / puppet-module-facter

Puppet module to manage Facter

Other

2 stars 23 forks source link

Adding support for Windows #67

Closed nmaludy closed 4 years ago

nmaludy commented 4 years ago

This is another PR to add support for Windows. Hopefully this is more concise than the others.

TODO

[x] Need to test the null values for facter::facts_d_mode in the Windows data actually performs the Hiera lookup correctly.
[x] Need to test the user/group of NT AUTHORITY\SYSTEM sets the proper user/group.
[x] Fix unit tests (seems a bunch of them are broken)
[x] Add spec tests for Windows OS

ghoneycutt commented 4 years ago

@nmaludy this is awesome work, thank you very much!!

nmaludy commented 4 years ago

OK, i got Travis to the point where it's passing linting and running the spec tests. Most of the specs are failing currently. I'll fix those next.

nmaludy commented 4 years ago

@ghoneycutt got tests written, the only one that is failing is https://github.com/ghoneycutt/puppet-module-facter/pull/67/files#diff-279972940b2611b2c7a177c5e1344902R133-R136

I think we do need the Optional[] around the $file and $facts_dir so we can fall back to using $facter::facts_file and $facter::facts_d_dir. Is that OK?