search

ghoneycutt / puppet-module-inittab

Puppet module to manage inittab
Other
2 stars 26 forks source link

Use facts #103

Closed term1n4l closed 5 years ago

term1n4l commented 5 years ago

v2.11.2 2019-03-29

Strongly typed params #97 Update to latest PDK #99 Fix Unit tests #100 Update facts variables to use facts hash #101 Add in module hiera data #102

term1n4l commented 5 years ago

The unit tests were stringently checking string values that are no longer returned in current versions of puppet. If you wish to check those values that stringently, you will have to write additional unit tests. Much of the unit test code was not even linting properly with rubocop and you had duplicate checks in the same set of describe blocks. I have removed these also, you will need to put these checks in new context blocks if you wish to maintain them.

ghoneycutt commented 5 years ago

@term1n4l I really appreciate your work on this module. Suggest doing small commits as contributions that address specific things. By sending this huge commit that changes everything it is impossible to merge. I would be very keen to merge in the changes to drop Puppet 3 and 4 as well as migrating to using hiera data in module and the use of data types in the manifests. I'm not excited about all the style changes imposed by rubocop that change code so its hard to merge without any other added benefit. I also can't just merge in the version changes to the metadata, redoing travisci and the testing processes.