search

ghoneycutt / puppet-module-inittab

Puppet module to manage inittab
Other
2 stars 26 forks source link

Facts update #104

Closed term1n4l closed 5 years ago

term1n4l commented 5 years ago

Update module to use facts hash for clarity as per #101

term1n4l commented 5 years ago

The build is failing because rubygem-update used by the bundler on travis-ci only supports ruby >= 2.3.0, This build is successful against Puppet 5 and Puppet 6

term1n4l commented 5 years ago

as per https://github.com/puppetlabs/pdk-templates/pull/171 we must move to using at least 2.7.8 of rubygems-update. I have therefore had to drop support for Puppet 3 in the module

term1n4l commented 5 years ago

note: description is not a valid field in metadata.json and is detected as an error. I have removed it as it is un-necessary and contains the same value as 'summary'.

term1n4l commented 5 years ago

I also reduced the line length on regex for ensure_ttys1 as it was over 140 chars and therefore rubocop complains.

term1n4l commented 5 years ago

puppet 3 is also incompatible with using the facts hash variable format

term1n4l commented 5 years ago

I bumped the ruby version on puppet 5 and 6 because these are the versions of ruby that those are currently using.

term1n4l commented 5 years ago

This is the least amount I could possibly do to bring the module up to date and use the facts hash instead of top scope facts vars. I could have left the ruby versions on puppet 5 and 6 alone, but they're currently using the versions I have pinned them at in .travis-ci.yml. The other thing I could have left was the line length on the regex, but for everyone using rubocop validation, the module would have thrown warnings. In order to use the facts hash and allow the builds to pass since rubygems-update 3.0.0 I had to drop support for Puppet 3. In order to bring your module up to date, dropping Puppet 3 is necessary. I will add the hiera data as a separate pull request (unless you want me to bundle it in here as well).

term1n4l commented 5 years ago

note: as of Puppet 4 the tests directory is now called examples, I have renamed it.