A little bit more than just RHEL8. Code used various legacy $::operatingsystemrelease and $::operatingsystemmajrelease facts, which meant it jumped back and forth from String comparison to RegExp comparison (and some Integer comparison). Changed everything to use modern, structured facts and standardized on $facts['os']['release']['major'] so everything can be String.
Probably needs to change minimum supported version of Puppet to '>= 4.0.0', as I think that is when structured facts were introduced.
A little bit more than just RHEL8. Code used various legacy $::operatingsystemrelease and $::operatingsystemmajrelease facts, which meant it jumped back and forth from String comparison to RegExp comparison (and some Integer comparison). Changed everything to use modern, structured facts and standardized on $facts['os']['release']['major'] so everything can be String.
Probably needs to change minimum supported version of Puppet to '>= 4.0.0', as I think that is when structured facts were introduced.