search

ghoneycutt / puppet-module-inittab

Puppet module to manage inittab
Other
2 stars 26 forks source link

resolves #57 Changed all instances of lsbmajdistrelease and lsbdistid to... #58

Closed mlehner616 closed 10 years ago

mlehner616 commented 10 years ago

... operatingsystemmajrelease and operatingsystem respectively. lsb facts require specific lsb packages from the OS repos.

ghoneycutt commented 10 years ago

It failed travis because the spec tests also need the same changes

mlehner616 commented 10 years ago

I looked for the test files in spec. I obviously looked right passed it. :( Updated pull request.

ghoneycutt commented 10 years ago

Do you know when operatingsystemmajrelease was introduced to facter? I want to note that you need at least that version of facter in the README under compatibility. I don't want to break functionality for people running this with an old version of facter.

mlehner616 commented 10 years ago

good question,

I found the commit that first introduced operatingsystemmajrelease (didn't realize it was relatively recent) puppetlabs/facter@43cff12b74aa18187f1501d812a9d61bfcf1aa9f (committed March 28, 2013 tag 1.7.0)

mlehner616 commented 10 years ago

Hi Garret, Does the README update look ok? Is there anything you need from me to accept this?

ghoneycutt commented 10 years ago

fixed by PR #59