search

ghoneycutt / puppet-module-inittab

Puppet module to manage inittab
Other
2 stars 26 forks source link

Support rhel5 xen #64

Closed ghoneycutt closed 10 years ago

ghoneycutt commented 10 years ago

@eburwja Could you take a crack at the spec tests? Should add a test for when virtual is xenu on EL5 and potentially fix the current test.

eburwja commented 10 years ago

Heh I’ve never done rspec stuff before, so it’ll be a learning experience.

From: Garrett Honeycutt [mailto:notifications@github.com] Sent: Thursday, April 17, 2014 20:09 To: ghoneycutt/puppet-module-inittab Cc: James Burwell Subject: Re: [puppet-module-inittab] Support rhel5 xen (#64)

@eburwjahttps://github.com/eburwja Could you take a crack at the spec tests? Should add a test for when virtual is xenu on EL5 and potentially fix the current test.

— Reply to this email directly or view it on GitHubhttps://github.com/ghoneycutt/puppet-module-inittab/pull/64#issuecomment-40783591.

ghoneycutt commented 10 years ago

So when I updated the template I removed an extra line that caused things to fail. Added back in this commit.

ghoneycutt commented 10 years ago

@eburwja this is actually a bit more to it.. I'm taking a look now

ghoneycutt commented 10 years ago

@eburwja Thanks for the contribution!

eburwja commented 10 years ago

I feel “special” now. :p :p :p

From: Garrett Honeycutt [mailto:notifications@github.com] Sent: Thursday, April 17, 2014 20:31 To: ghoneycutt/puppet-module-inittab Cc: James Burwell Subject: Re: [puppet-module-inittab] Support rhel5 xen (#64)

@eburwjahttps://github.com/eburwja Thanks for the contribution!

— Reply to this email directly or view it on GitHubhttps://github.com/ghoneycutt/puppet-module-inittab/pull/64#issuecomment-40784288.