search

ghoneycutt / puppet-module-nfs

Puppet module to manage NFS
Other
4 stars 30 forks source link

Added Solaris 11 support #36

Closed nalyanyam closed 10 years ago

nalyanyam commented 10 years ago

Added Solaris 11 support, On older Solaris, 'sun' was always the default init provider, but on a newly installed Solaris 11, 'sun' seems not to be the default provider - and package check fails.

Not sure if this implementation is in the best way.

ghoneycutt commented 10 years ago

@nalyanyam This is awesome work! Really close to a merge.

nalyanyam commented 10 years ago

@ghoneycutt I have now updated the code so that package provider specification only affects Solaris OS, Please check and see if this is ok.

nalyanyam commented 10 years ago

@ghoneycutt Fixed the spec tests. Was not clear at first because of this new style spec test code. However, I find this new style to be easier in terms of adding more tests & OS support. Please check.

ghoneycutt commented 10 years ago

@Phil-Friderici would you mind testing this? I don't have access to Solaris 11.

nalyanyam commented 10 years ago

As we wait for feedback, please do not merge yet. I would like to do some more tests with different client versions and see the behavior, and probably change the code so that provider is changed only if specified in hiera, else the defaults take place.

nalyanyam commented 10 years ago

Actually newer puppet clients At least (3..) distinguish packages properly on Solaris 11 between the legacy packaging mode and the new packaging style - So i will have to change code to reflect this new style properly. I will close this PR & make a new commit. Thanks

Phil-Friderici commented 10 years ago

@ghoneycutt sorry, still no Solaris guy ;) But I think nalyanyam is testing this with other Hubs around the globe.