search

ghoneycutt / puppet-module-nfs

Puppet module to manage NFS
Other
4 stars 30 forks source link

CentOS requires the package redhat-lsb #41

Closed gammamatrix closed 7 years ago

gammamatrix commented 10 years ago

The variable $::lsbmajdistrelease in init.pp will be nil if the package redhat-lsb is not installed.

This will result with the failure message:

"nfs module only supports EL 5 and 6 and lsbmajdistrelease was detected as..."

Here is the package to require:

package { 'redhat-lsb':
    ensure  => present,
}

The redhat-lsb package is not a part of the minimal install for CentOS 6.

lesaux commented 10 years ago

agreed! ghoneycutt: any reason to prefer $::lsbmajdistrelease in favor of $$::operatingsystemmajrelease? (redhat-lsb not needed)

ghoneycutt commented 10 years ago

operatingsystemmajrelease is a fairly new fact in comparison to this code base. Actually looking to do this with other modules. Since the dawn of Puppet until three months ago, you had to have redhat-lsb to have the lsb* facts, which were used all over the show. Happy to see that we will not need them any longer and am quite happy to merge any PR's to fix this.

https://github.com/ghoneycutt/puppet-module-pam/pull/67

rnelson0 commented 9 years ago

@ghoneycutt The PR above should fix the issue and bump the version to 1.8.1 so it's ready to go to the forge.

ghoneycutt commented 7 years ago

Thanks everyone. This has been fixed.