search

ghoneycutt / puppet-module-nfs

Puppet module to manage NFS
Other
4 stars 30 forks source link

Add EL7 support #43

Closed EmilienM closed 9 years ago

EmilienM commented 10 years ago

Add support for RHEL7 & CentOS7 release in this module.

EmilienM commented 10 years ago

Test pass for me locally. Is it something wrong I'm missing? My patch is pretty simple :-)

sbadia commented 10 years ago

PR Fixed (typo in metadata.json https://github.com/enovance/puppet-module-nfs/compare/0239af321b292c9862554fa24baa6143c91cfd0d...rhel7_support), thanks!

EmilienM commented 9 years ago

@ghoneycutt after 2 months, could you review & merge this patch please?

ghoneycutt commented 9 years ago

There is no nfs service?

EmilienM commented 9 years ago

@ghoneycutt I fixed the lint issue and answered to your question. There is NFS on EL7, we have it working with this patch. Thanks for review & merge if it's OK.

EmilienM commented 9 years ago

@ghoneycutt I don't mind if you don't merge my pull-request, I was trying to help your module to be EL7 ready. Anyway, I hope I'll be able to drop your modules from my dependencies, because to be honest... all your dependencies are really a pain to manage.

ghoneycutt commented 9 years ago

@EmilienM I appreciate the PR and totally my fault I missed your latest update to it. I'm curious what you mean by all of the dependencies and them being difficult to manage. Do you have any suggestions? I can also be reached directly via email with code at garretthoneycutt.com

ghoneycutt commented 9 years ago

Added a couple of tests to this PR in #44