search

ghoneycutt / puppet-module-nfs

Puppet module to manage NFS
Other
4 stars 30 forks source link

WIP - Support OmniOS 5.11 #66

Closed ghoneycutt closed 8 years ago

ghoneycutt commented 8 years ago

@westbywest

westbywest commented 8 years ago

I tested your PR on a fork I've been keeping (since I also have some incomplete changes for improved EL7 compatibility). https://github.com/westbywest/puppet-module-nfs/commit/c973ff0293aa4f5897520ed6732063491209a57c

I rebuilt the OmniOS vagrant guest from scratch with this PR, and it looks good. No more unsatisfied dependencies errors as mentioned in https://github.com/ghoneycutt/puppet-module-nfs/issues/63 .

ghoneycutt commented 8 years ago

Awesome! Could you test with the code in this branch only and not intermixed with your changes? That would give me confirmation that this code really is good, at which point I'll write up the spec tests.

westbywest commented 8 years ago

Ack, nope, looks like I may have had a race condition that permitted the OmniOS vagrant guest I just tested on to start up fine. Repeated test shows that puppet/OmniOS don't like an array being passed in the 'name' attribute for svcadm service provider:

Error: Could not start Service[nfs_service]: Execution of '/usr/sbin/svcadm enable -s nfs/client nfs/nlockmgr nfs/status' returned 1: svcadm: Partial FMRI matches multiple instances
westbywest commented 8 years ago

Offering a revised PR: https://github.com/ghoneycutt/puppet-module-nfs/pull/67