search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

switch to ensure_packages #127

Closed jcpunk closed 8 years ago

jcpunk commented 8 years ago

Some of my pam related packages come out of other modules, this silences the issue for me.

ghoneycutt commented 8 years ago

@jcpunk This is failing Travis as the tests look for the package resource. Could you take a look at those?

@Phil-Friderici any experience with testing ensure_package() ?

Phil-Friderici commented 8 years ago

I have used ensure_resource() lately and it should be using mostly the same testing as ensure_package(). In the tests, I have defined the resource as pre_condition and test that it doesn't fail like it does with package{}.

For inspiration, please have a look at this commit: https://github.com/kylefu8/puppet-module-tweaks/commit/58f5f13886c7f601ffe24d4534c285d2117e8d6a

jcpunk commented 8 years ago

I'll close this PR for now and open a new one once I've got all that working