ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

Add param to manage nsswitch service from pam module. #132

Closed mandos closed 7 years ago

mandos commented 8 years ago

Default behaviour is to include nsswitch module inside pam module, this param allow to use different way of configuration nsswitch service. Backward compaltibility was kept (default: true).

tehmaspc commented 8 years ago

Need this feature as well. Thanks!

mandos commented 8 years ago

About failed tests on travis-ci:

Gem::InstallError: json_pure requires Ruby version ~> 2.0. Installing json 1.8.3 An error occurred while installing json_pure (2.0.2), and Bundler cannot

@ghoneycutt Why is this happend? Is it bug in travis/rvm? I checked it locally at rbenv and bundler installed me json_pure (1.8.3).

ghoneycutt commented 8 years ago

It needs json_pure pinned in the Gemfile like https://github.com/Ericsson/puppet-module-cron/blob/master/Gemfile#L34

I can take that on.

ghoneycutt commented 8 years ago

I fixed the Gemfile problem with PR #140 while adding support for ruby 2.3.1. Please rebase against master to bring that in.

You can do that by doing this.

git checkout master
git pull upstream master # provided you have my remote named 'upstream'
git checkout manage_nsswitch
git rebase master
mandos commented 8 years ago

Today I will do changes according your sugestions.

tehmaspc commented 7 years ago

@Mandos @ghoneycutt

any chance of getting this merged in? thanks very much!

ghoneycutt commented 7 years ago

Thank you everyone! I rebased the commits, squashing where appropriate and moving the .gitignore piece to its own commit. See PR #149

tehmaspc commented 7 years ago

@ghoneycutt rock! thanks a bunch buddy!