search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

Add template for performing custom sshd pam config #141

Closed boandersson closed 8 years ago

boandersson commented 8 years ago

Specific use case is to be able to supply options to pam_vas3 that are specifically needed (and should only be configured) for sshd to resolv intermittent ssh login failures with QAS.

ghoneycutt commented 8 years ago

Thanks @boandersson

@Phil-Friderici what do you think?

ghoneycutt commented 8 years ago

@boandersson would it be possible to just update the default VAS entries in the code?

Phil-Friderici commented 8 years ago

An alternative approach would be to bring all sshd.$osfamily.erb template content into the code. This would become a bigger refactoring of the functionality. Which I would only do on a major version update.

So I can understand why @boandersson chose this way.

ghoneycutt commented 8 years ago

I'm going to defer to @Phil-Friderici on this. When he gives the thumbs up, I'll merge and release.

Phil-Friderici commented 8 years ago

@boandersson Think we only need to agree how detailed we want to test here. After that, please squash all commits into one for a nice commit history :)

boandersson commented 8 years ago

Added test updates from @Phil-Friderici. Let me know what you think before I squash any commits

Phil-Friderici commented 8 years ago

From my perspective this is complete. @boandersson please squash it into one commit. @ghoneycutt please have a second look and merge it if you are ok with it too.

Phil-Friderici commented 8 years ago

@boandersson thanks for squashing @ghoneycutt looks good to me now :)

ghoneycutt commented 8 years ago

Thank you both!

ghoneycutt commented 8 years ago

Released in v2.27.0

boandersson commented 8 years ago

Thanks for code review and merge @ghoneycutt !