search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

Ubuntu 16.04 #152

Closed dsundq closed 7 years ago

dsundq commented 7 years ago

Add support for vas

ghoneycutt commented 7 years ago

Hi, thank you for the contribution. We need a test that shows that if you have ubuntu 16.04 and vas 4 that it shows the proper files and and their content through the use of fixtures.

boandersson commented 7 years ago

Hi @ghoneycutt, can you please clarify what you mean regarding tests? We have the tests that are included since ubuntu1604 is in the platforms hash - those tests towards the default vas_major_version (4) and are seen in the spec output: "with vas params on Debian with lsbdistrelease 16.04". Do we need other tests as well?

boandersson commented 7 years ago

Hi @ghoneycutt, do you have any clarification on what tests you want us to add?

ghoneycutt commented 7 years ago

Thank you everyone! I went ahead and rebased and added a commit to support Puppet 4.9 in PR #153