Puppet5 and 6 compatibility

treydock commented 6 years ago

Place to discuss changes for next major release that will introduce puppet5 compatibility. We are working against the puppet5 branch. https://github.com/ghoneycutt/puppet-module-pam/tree/puppet5

[x] Remove VAS logic and move to examples
[x] Use module hiera data
[x] use new readme format (https://github.com/ghoneycutt/puppet-module-bind/blob/master/README.md)
[x] Phil to sign off on spec testing
[x] Get rid of lsb* facts (Thanks to @v4ld3r5 for doing these for Suse. We'll need to ensure they are all gone)
[x] stop depending on ghoneycutt/common (need to migrate mkdir_p to its own module, though just using an exec here first is OK so we don't have another dependency to wait on)
[x] switch to use trlinking/nsswitch since it is Puppet Approved
[x] nsswitch supports puppet v5 (https://github.com/trlinkin/puppet-nsswitch/pull/27)
[x] use newer readme format that is needed for Approved status - PR #189
[x] @ghoneycutt Can you please rebase puppet5 branch with master to get examples directory created.
[x] replace create_resources() - PR #190
[x] Phil to sign off that the new version works in his environment

ghoneycutt commented 6 years ago

Rebased. Had to force push, so hope it doesnt mess up your branches.

ghoneycutt commented 6 years ago

cc @Phil-Friderici

treydock commented 6 years ago

@ghoneycutt I have hiera5 changes staged. I'll rebase and open PR in coming days.

ArVincentr commented 6 years ago

Seems since Facter 2.2 some changes were made to lsbmajdistrelease as per https://docs.puppet.com/facter/2.2/release_notes.html#significant-changes-to-existing-facts

would it be possible to use "operatingsystemmajrelease" for the puppet 5 release and facter 3.x ?
fact doens't return anything on SLES systems.

Regards

treydock commented 6 years ago

@ghoneycutt Would you be open to idea of switching to https://forge.puppet.com/trlinkin/nsswitch for nsswitch dependency? Or making the dependency something a site has to add if they choose to set manage_nsswitch to true. Would be a non issue if I could find a way to make puppet not tell me about missing dependencies without suppressing all warnings:

Warning: ModuleLoader: module 'pam' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules
   (file & line not available)

├─┬ ghoneycutt-pam (v2.33.0)
│ ├── UNMET DEPENDENCY ghoneycutt-nsswitch (>= 1.3.0 < 2.0.0)
│ └── ghoneycutt-common (v1.5.0)

ghoneycutt commented 6 years ago

We can switch to Tom's module since it is approved. We'll need to do some work on it, specifically the lack of spec tests.

Phil-Friderici commented 6 years ago

Added some refactoring for the common* files in https://github.com/ghoneycutt/puppet-module-pam/pull/172. If you like this refactoring I will move as much data into Hiera 5 module data to clean up the code even more.

Phil-Friderici commented 6 years ago

Converted the README to new readme format in https://github.com/ghoneycutt/puppet-module-pam/pull/174

Phil-Friderici commented 6 years ago

Will work on refactors for code and spec tests in https://github.com/ghoneycutt/puppet-module-pam/pull/175

ghoneycutt commented 6 years ago

waiting on https://github.com/trlinkin/puppet-nsswitch/pull/27 https://tickets.puppetlabs.com/browse/MODULES-7084

ghoneycutt commented 6 years ago

Will merge from https://github.com/ghoneycutt/puppet-module-pam/pull/179

ghoneycutt / puppet-module-pam

Puppet5 and 6 compatibility #168