Closed treydock closed 5 years ago
Rebased. Had to force push, so hope it doesnt mess up your branches.
cc @Phil-Friderici
@ghoneycutt I have hiera5 changes staged. I'll rebase and open PR in coming days.
Seems since Facter 2.2 some changes were made to lsbmajdistrelease as per https://docs.puppet.com/facter/2.2/release_notes.html#significant-changes-to-existing-facts
would it be possible to use "operatingsystemmajrelease" for the puppet 5 release and facter 3.x ?
fact doens't return anything on SLES systems.
Regards
@ghoneycutt Would you be open to idea of switching to https://forge.puppet.com/trlinkin/nsswitch for nsswitch dependency? Or making the dependency something a site has to add if they choose to set manage_nsswitch
to true. Would be a non issue if I could find a way to make puppet not tell me about missing dependencies without suppressing all warnings:
Warning: ModuleLoader: module 'pam' has unresolved dependencies - it will only see those that are resolved. Use 'puppet module list --tree' to see information about modules
(file & line not available)
├─┬ ghoneycutt-pam (v2.33.0)
│ ├── UNMET DEPENDENCY ghoneycutt-nsswitch (>= 1.3.0 < 2.0.0)
│ └── ghoneycutt-common (v1.5.0)
We can switch to Tom's module since it is approved. We'll need to do some work on it, specifically the lack of spec tests.
Added some refactoring for the common* files in https://github.com/ghoneycutt/puppet-module-pam/pull/172. If you like this refactoring I will move as much data into Hiera 5 module data to clean up the code even more.
Converted the README to new readme format
in https://github.com/ghoneycutt/puppet-module-pam/pull/174
Will work on refactors for code and spec tests in https://github.com/ghoneycutt/puppet-module-pam/pull/175
Will merge from https://github.com/ghoneycutt/puppet-module-pam/pull/179
Place to discuss changes for next major release that will introduce puppet5 compatibility. We are working against the
puppet5
branch. https://github.com/ghoneycutt/puppet-module-pam/tree/puppet5create_resources()
- PR #190