Replacing lsb* facts for SuSE distros

ghoneycutt / puppet-module-pam

Puppet module to manage PAM

Other

18 stars 79 forks source link

Replacing lsb* facts for SuSE distros #171

Closed v4ld3r5 closed 6 years ago

v4ld3r5 commented 6 years ago

Hi, This is related to issue #168 . Fixed for SuSE distros. There are some other lsb* facts for Debian/Ubuntu for which I'm not sure. Nevertheless I can test this on SLES 11 and 12

Best regards,

ghoneycutt commented 6 years ago

@v4ld3r5 Thank you! This is awesome and needed work, especially on Suse!

We are actively working to do a major version bump on this module and get it to support Puppet5 and the latest language changes introduced in Puppet4.

We are discussing what needs done and working at it in Issue #168

Part of that work is this, replacing lsb* facts. Would you be interested in doing that change against the puppet5 branch?

https://github.com/ghoneycutt/puppet-module-pam/tree/puppet5

v4ld3r5 commented 6 years ago

Hi, Sure, I believe this PR is targetting the puppet5 branch already. Otherwise let me know and will correct asap

Best regards,

ghoneycutt commented 6 years ago

Doh! Thanks!