search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

Refactors #172

Closed Phil-Friderici closed 6 years ago

Phil-Friderici commented 6 years ago

Using iterations with each instead of resource declarations for each single common* file on Linux systems.

Phil-Friderici commented 6 years ago

As this is a quite complex refactor I have taken extra care to NOT change the existing spec tests. The only change needed does adjust the internaly used resource names for $common_session_noninteractive_file on Debian/Ubuntu.

Phil-Friderici commented 6 years ago

Added some refactoring for the common* files in https://github.com/ghoneycutt/puppet-module-pam/pull/172.

Phil-Friderici commented 6 years ago

If you like this refactoring I will move as much data into Hiera 5 module data to clean up the code even more.

Phil-Friderici commented 6 years ago

Main class looks so much cleaner now without all theses osfamily dependend settings. Based on the great work @treydock did in https://github.com/ghoneycutt/puppet-module-pam/commit/a8e97864957089a63611ec0ac128b5b88511f729 I have now moved the rest into hiera data.

Using iteration for the common* files to get rid of the os specific resource collections.

Finalise: Use module hiera data Fix: Get rid of lsb* facts

ghoneycutt commented 6 years ago

Thank you!