search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

Add support for Ubuntu 18.04 #178

Closed KlavsKlavsen closed 5 years ago

KlavsKlavsen commented 6 years ago

Updated pam templates to match what is in 18.04.

KlavsKlavsen commented 6 years ago

Travis test seems to fail due to something unrelated to my code :(

nbentoumi commented 6 years ago

@ghoneycutt @KlavsKlavsen , i did a test on ubuntu 18.04, don't see any issue. :+1:

gavmain commented 6 years ago

Hi @KlavsKlavsen, I appreciate the work you've done and I'm eager to see it pulled. It looks like this maybe failing the CI tests due to missing spec fixtures for ubuntu1804.

KlavsKlavsen commented 6 years ago

@gavmain I've tried to do so - by looking at the commit that added Ubuntu 16.04 support.. it fails with an odd failure, where I can't seem to figure out what I actually did wrong.. Can you help me figure it out? (if I want to run the fixtures spec on my own end.. Have you got any hint as to what to setup on an ubuntu to be able to do that?) -- and perhaps that could be put in README.. as "Developers documentation" or something :)

gavmain commented 6 years ago

I was a bit worried whether VAS was compatible with Ubuntu 18.04, but checking their site they support all current Ubuntu releases.

If that is the case, I think you are safe to update the version on this line, from: if check == 'vas' and v[:osfamily] == 'Debian' and v[:release] == '18.04' to: if check == 'vas' and v[:osfamily] == 'Debian' and v[:release] == '20.04' and see if that now passes the CI tests.

I'm basing this assumption on the commit by Daniel Sundqvist - who is no longer on Github by the looks of it - where he added VAS support for 16.04.

KlavsKlavsen commented 6 years ago

Changed that - and the test fails the same :(

gavmain commented 6 years ago

I'm just having a look. I wonder if @ghoneycutt can cast some light on this?

nbentoumi commented 6 years ago

VAS is compatible with Ubuntu 18.04, performed a test and working fine

gavmain commented 6 years ago

The Gemfile looks like it needs updating, specifically this line relating to the metadata-json-lint. It requires Ruby 2.0 or higher according to the metadata-json-lint readme. For the job #609.1 I found a similar error reported to the metadata-json-lint project.

It does look like you are facing a Ruby dependency nightmare. Digging further I see @ghoneycutt has a branch called v3 which has a significant number of changes to the build files and has dropped a number of old versions. I wonder if it is best to merge your work into there. We'll hopefully hear back from @ghoneycutt on what to do.

KlavsKlavsen commented 6 years ago

But those errors must have been there before then.. I have changed nothing that should cause this.. Unless the build system is done so it just fetches "the latest" version of dependencies it uses - and I happened to make this patch - when the latest versions broke the test system :(

KlavsKlavsen commented 6 years ago

@gavmain I've merged the same change as @fbarbeira - to sshd.ubuntu18.erb

ghoneycutt commented 5 years ago

We have released a new major version of this module and greatly appreciate your efforts. The new way to support new platforms should be easier as it mostly involves just adding data. Please consider using the new version which supports Puppet 5 and 6 and re-working this PR.