Add suport for Ubuntu 18.04

ghoneycutt / puppet-module-pam

Puppet module to manage PAM

Other

18 stars 80 forks source link

Add suport for Ubuntu 18.04 #186

Closed amateo closed 5 years ago

amateo commented 6 years ago

This PR is to provide support for Ubuntu 18.04. By default, it leaves pam.d files with the default configuration provided by ubuntu, except for sshd where is added pam_access.

amateo commented 5 years ago

Hi @ghoneycutt,

a few months ago I made this PR. It failed with problems not directly related with my commit (I guess, I'm not familiar with tests).

Should I fix something?

ghoneycutt commented 5 years ago

Hi @amateo I'm working on releases v3 which is a major upgrade and needs 18.04 support. Could you target the v3 branch please?

ghoneycutt commented 5 years ago

It should take copying and pasting info into data/os/Ubuntu/18.04.yaml and adding fact info to spec/spec_helper.rb.

ghoneycutt commented 5 years ago

We have released a new major version of this module and greatly appreciate your efforts. The new way to support new platforms should be easier as it mostly involves just adding data. Please consider using the new version which supports Puppet 5 and 6 and re-working this PR.