search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

Add support for Ubuntu 20.04 #221

Closed runejuhl closed 1 year ago

runejuhl commented 4 years ago

This PR adds support for Ubuntu 20.04 (focal fossa).

I've based the PAM defaults on the current ubuntu:20.04 Docker image; there should only be minor differences compared to Ubuntu 18.04.

I had an issue with conflicting dependies on stdlib versions and opted to simply bump the version ranges. There might be a better fix, but ultimately it's your decision if you want to allow users to use older stdlib versions.

anders-larsson commented 4 years ago

Hello,

We're interesting in seeing support for Ubuntu 20.04 in puppet-module-pam. What's the current status of this pull request?

Thanks! :)

runejuhl commented 4 years ago

Hello,

We're interesting in seeing support for Ubuntu 20.04 in puppet-module-pam. What's the current status of this pull request?

Thanks! :)

Hi Anders,

I haven't looked into the error you get when not bumping stdlib. 4.22.0 is from November 2017 (b66a45ed4cf60715f6565555b2ef1f1aa8b9890b) and I'd be fine with bumping to something newer. Ultimately it's up to @ghoneycutt :slightly_smiling_face:

If you and he is up for it, perhaps you could run the tests with a stdlib dependency newer than 4.22.0 but older than 5.0.0 (597769a73cc194ea9daa8a49b5707be45ad5240b)?

ghoneycutt commented 4 years ago

@runejuhl Is the data from the fixtures from a default, stock install of the OS? We want to keep our defaults in line with the platform.

ghoneycutt commented 4 years ago

The README.md also needs updated. Check out https://github.com/ghoneycutt/puppet-module-pam#limitations

dsundq commented 4 years ago

Hi, Do you have any status on this pull request? Thanks

ghoneycutt commented 4 years ago

Hi @dsundq I'm waiting on @runejuhl to reply regarding if it is from a stock install as well as small change to the travis configs and README. You're welcome to make a PR based off of this one and add that, then I can get it merged.

runejuhl commented 4 years ago

Hi all,

Sorry for the delay. I'll see if I can find some time to get this done today :crossed_fingers:

runejuhl commented 4 years ago

@runejuhl Is the data from the fixtures from a default, stock install of the OS? We want to keep our defaults in line with the platform.

Yes; I based the files on the latest Ubuntu 20.04 Docker image

runejuhl commented 4 years ago

The README.md also needs updated. Check out https://github.com/ghoneycutt/puppet-module-pam#limitations

Done! ...and the rest should be fixed too. Haven't run tests locally, but let's have Travis do a run first and I'll check up on any errors today.

amateo commented 4 years ago

@runejuhl there is also a pending fix in init.pp, at the fail message for Ubuntu. You have to update it to indicate that 20.04 is also supported now.

runejuhl commented 4 years ago

@runejuhl there is also a pending fix in init.pp, at the fail message for Ubuntu. You have to update it to indicate that 20.04 is also supported now.

Good catch -- I'll fix it right away

runejuhl commented 4 years ago

Err, any idea why all checks failed? Is it a Travis issue? How do you trigger a new CI run? Seems to work fine locally.

amateo commented 4 years ago

I had this same problem with the PR I tried yesterday.

anders-larsson commented 4 years ago

@runejuhl If you recommit (using --amend) and force push it, it should re-trigger the Travis job. Otherwise @ghoneycutt should be able to to trigger it.

treydock commented 1 year ago

There appears to be Ubuntu 20.04 support added in a different PR.

treydock commented 1 year ago

The PR that added this was #225