search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 79 forks source link

add amazon linux 2 support #229

Closed ghoneycutt closed 1 year ago

ghoneycutt commented 4 years ago

CC: @mears148

ghoneycutt commented 4 years ago

@mears148 looks like the tests and the configs don't match up

ghoneycutt commented 3 years ago

Fixes #214

ghoneycutt commented 3 years ago

@mears148 looking at this again and it is unclear to me if Amazon Linux 2 uses pam_password_auth_ac and pam_system_auth_ac as the spec tests show with their filenames or as you specify in the data.

https://github.com/ghoneycutt/puppet-module-pam/pull/229/files#diff-3cad40562c0add610a6492cef06451e4ce7201b60b19c186b28096b0ef0613cb

Could you please clarify what is actually used?

mears148 commented 3 years ago

@mears148 looking at this again and it is unclear to me if Amazon Linux 2 uses pam_password_auth_ac and pam_system_auth_ac as the spec tests show with their filenames or as you specify in the data.

https://github.com/ghoneycutt/puppet-module-pam/pull/229/files#diff-3cad40562c0add610a6492cef06451e4ce7201b60b19c186b28096b0ef0613cb

Could you please clarify what is actually used?

I apologize, I missed that. The correct files to be used are system-auth-ac and password-auth-ac as they are referenced by symbolic links from system-auth and password-auth so that the authconfig utility recognizes these are custom configuration files and should not be overwritten.

mears148 commented 3 years ago

Essentially it should look almost identical to RHEL 7.

lduriez commented 3 years ago

Hello guys, I'm really interested in that merge. I don't know much about travis-ci but if I can help in anything please let me know.

lduriez commented 3 years ago

What I understand from the travis-ci is that parameters are missing in spec_helpher.rb for amzn2 (el2) : https://github.com/ghoneycutt/puppet-module-pam/blob/amz2/spec/spec_helper.rb

You should add this to el2 part : :pam_d_login :pam_d_sshd

lduriez commented 3 years ago

Hi any news for that ?

treydock commented 1 year ago

Replaced by #259

ghoneycutt commented 1 year ago

Thank you for your efforts!

Released in v3.10.0