search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 80 forks source link

Add config option for session-noninteractive #238

Closed promasu closed 1 year ago

promasu commented 2 years ago

Just stumbled across this PR. Is the new commit what you meant by needs tests? I did not manage to find a test for the other pam_FOOBAR_lines parameters.

Thanks!

ghoneycutt commented 1 year ago

Thank you for your contribution. Looks like you can just add your data to pam_session_lines and then there is no need for another parameter. This also keeps the module simpler and you know all the lines come from the one array instead of them occurring in two.

promasu commented 1 year ago

Thanks for looking into this. Yes you can do that and this stays the default with this PR, but there are usecases where you want different PAM-Lines for interactive and non-interactive sessions. This is why I opened this PR in the first place