search

ghoneycutt / puppet-module-pam

Puppet module to manage PAM
Other
18 stars 78 forks source link

Send notice instead of hard fail #98

Closed propyless closed 9 years ago

propyless commented 9 years ago

thought it might be better to send a notice rather than fail the whole puppet run. this is just to see if you think this might be better.

//propy

propyless commented 9 years ago

Alright yeah thats what I thought as well. If it the OS does not support pam fragments, the puppet run should fail imo. We had some mixed opinions about it failing here at work and I thought i'd provide an alternate solution.

ghoneycutt commented 9 years ago

Thanks for asking. Always better to fail the catalog when unsure of compatibility as opposed to doing something that may not work as intended. If you checkout out the pam class you'll see the osfamily case statement where the defaults are always to fail.

propyless commented 9 years ago

There opinion derives from the fact that people (including us) have been using fragments and sle 10.x and now we would receive fails.

Phil-Friderici commented 9 years ago

thanks for your thoughts :)

propyless commented 9 years ago

closed because it should fail.