Made host_aliases configurable

ghoneycutt / puppet-module-ssh

Puppet module to manage SSH

Other

34 stars 184 forks source link

Made host_aliases configurable #327

Closed Fabian1976 closed 1 year ago

Fabian1976 commented 5 years ago

We use IPA for our host registration and authentication. When the SSH module adds the FQDN and the HOSTNAME (without domain suffix) to the global known_hosts, auto-complate with SSH only uses the HOSTNAME. We want to be able to remove HOSTNAME and only have FQDN and IPADDRESS in the know_host_file. With this addition the default behaviour stays the same but we have the option to alter the host_alias.

Could you please allow this change?

I didn't change the indentation of the parameters on purpose so that it is easy to see what has changed.

Phil-Friderici commented 1 year ago

Closing this PR as it was made for the v3 version of the module which is outdated now. v4 does not support for exporting and importing SSH keys anymore.

Fabian1976 commented 1 year ago

Ok, so when i write a new PR for version 4, are you going to wait another 3+ years and then "suddenly" react and decline because it was written for an old version?

Or is there another reason why it was not merged in the first place?

Phil-Friderici commented 1 year ago

The functionality to export and import SSH keys was causing a lot of issues in large environments with constantly changing servers. Therefore it was removed in v4.

I can not speak for the module maintainer (@ghoneycutt) but I think it should be possible to re-add the functionality when it is disabled by default.