search

ghoneycutt / puppet-module-ssh

Puppet module to manage SSH
Other
34 stars 184 forks source link

Update init.pp #364

Closed jonathan-dill-nih closed 2 years ago

jonathan-dill-nih commented 2 years ago

serverkeybits is deprecated in 7.4 but versioncmp($::operatingsystemrelease, '7.4') < 0 is false for EL 7.4 should be <= 0

jonathan-dill-nih commented 2 years ago

A more universal fix might be versioncmp($::ssh_version_numeric, '7.6') < 0 || "${::ssh_version}" =~ /^OpenSSH_7.6p/ all the different numbering schemes for OS versions get a bit messy, need to check my syntax. It's unfortunate that there is no way to distinguish the p1 via $::ssh_version and plain 7.6 does not have it.

jonathan-dill-nih commented 2 years ago

Nevermind I was reading the rule as the inverse.