search

ghoneycutt / puppet-module-ssh

Puppet module to manage SSH
Other
34 stars 184 forks source link

Prepare the docs #375

Closed Phil-Friderici closed 2 years ago

ghoneycutt commented 2 years ago

This is awesome! It should make it much easier for the community to add platforms.

Phil-Friderici commented 2 years ago

Glad you like it. Easy maintenance is one of the key intentions here.

I have an idea and would like to know what you think of it: We have removed all these nasty checks for compatibility of SSH parameters. That makes the code much easier to read and maintain. On the other side there is a risk of a misconfigured SSH daemon not re-starting successfully which then renders systems to become unreachable for manual fixing. So I am wondering myself if we could add a passive class with these sanity checks. People who like the checks would need to activate that extra class. I guess it shouldn't be too much effort and it should only cover the real killer combinations.

ghoneycutt commented 2 years ago

Guessing this would be things like if $ssh_version < X, then param Y must be undef ? I'm OK with a class that does all that so long as you can disable its inclusion as over time or the addition of platforms it could get hard to maintain.

Phil-Friderici commented 2 years ago

Guessing this would be things like if $ssh_version < X, then param Y must be undef ? I'm OK with a class that does all that so long as you can disable its inclusion as over time or the addition of platforms it could get hard to maintain.

I am not sure if these sanity checks where one of the 'selling points' of this module. Maybe we should wait if the users do request the sanity checks before adding something that isn't asked for. Also I would like to get this work to an end soon :)