search

ghosh / microtip

💬 Minimal, accessible, ultra lightweight css tooltip library. Just 1kb.
https://microtip.vercel.app/
MIT License
1.38k stars 74 forks source link

replace “minifier” with “clean-css” #4

Closed marcobiedermann closed 7 years ago

marcobiedermann commented 7 years ago

I've replaces minifier with clean-css which saves some extra bytes. It is also way more maintained and used.

before: 6195 bytes
after : 6041 bytes
diff  :  154 bytes

Not much bit every byte counts :)

ghosh commented 7 years ago

@marcobiedermann Thanks! This is fantastic. Merged.

marcobiedermann commented 7 years ago

@ghosh You are very welcome :)

I've checked package.json after merge but it does not look right. Are you sure you merged me PR into master?

ghosh commented 7 years ago

@marcobiedermann Hi, yes I did merge it at one point - see 553ce6b

However, there was an issue where the minified code was breaking some of the styles of the tooltips. At that point, I didn't have time to investigate, hence reverted back to older minifier. I do hope to switch it out with clean-css at som point though.

marcobiedermann commented 7 years ago

Alright, I'll check the ouput again